Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Add $lineProgress expression variable #13192

Merged
merged 2 commits into from
Oct 30, 2018
Merged

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Oct 25, 2018

Implemented the $lineProgress expression variable described in MGLLineStyleLayer.lineGradient documentation as a counterpart to the style specification’s line-progress expression operator. Also added an NSExpression.lineProgressVariableExpression class property for this variable.

Fixed a typo in the “Information for Style Authors” guide.

Fixes #12917.

/cc @fabian-guerra

@1ec5 1ec5 added GL JS parity For feature parity with Mapbox GL JS iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS crash runtime styling labels Oct 25, 2018
@1ec5 1ec5 added this to the ios-v4.6.0-h-release milestone Oct 25, 2018
@1ec5 1ec5 self-assigned this Oct 25, 2018
@1ec5 1ec5 force-pushed the 1ec5-e8n-line-progress-12917 branch from 40d4a46 to eb12456 Compare October 25, 2018 12:01
platform/ios/CHANGELOG.md Outdated Show resolved Hide resolved
@1ec5 1ec5 added the navigation For the Mapbox Navigation SDK for Android or iOS or navigation use cases in general label Oct 28, 2018
@1ec5 1ec5 force-pushed the 1ec5-e8n-line-progress-12917 branch from eb12456 to a01eb04 Compare October 28, 2018 06:06
@1ec5 1ec5 force-pushed the 1ec5-e8n-line-progress-12917 branch from a01eb04 to 796256c Compare October 28, 2018 06:40
Copy link
Contributor

@fabian-guerra fabian-guerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@1ec5 1ec5 merged commit 3f31468 into master Oct 30, 2018
@1ec5 1ec5 deleted the 1ec5-e8n-line-progress-12917 branch October 30, 2018 21:27
@friedbunny
Copy link
Contributor

Noting that this wasn’t an issue for Android, as #12575 originally included support on that platform.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
crash GL JS parity For feature parity with Mapbox GL JS iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS navigation For the Mapbox Navigation SDK for Android or iOS or navigation use cases in general runtime styling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants