This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
android.hardware.location.gps feature should not be required #10347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zugaldia
reviewed
Nov 1, 2017
| package="com.mapbox.mapboxsdk"> | ||
|
|
||
| <uses-feature android:glEsVersion="0x00020000" android:required="true" /> | ||
| <uses-feature android:name="android.hardware.wifi" android:required="false" /> <!-- Implied by ACCESS_WIFI_STATE. --> | ||
| <uses-feature android:name="android.hardware.location.gps" android:required="false" tools:replace="required" /> |
There was a problem hiding this comment.
@osana could you run a quick test using the test app? You should be able to see the merged manifest of the app in Studio and verify whether tools:replace="required" is needed. Thanks!
tobrun
approved these changes
Nov 1, 2017
This was referenced Nov 2, 2017
22 tasks
23 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10345