This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Blacklist VAO usage on adreno 3xx #10253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivovandongen
added
Android
src/mbgl/gl/context.cpp
Outdated
| vertexArray->deleteVertexArrays; | ||
| // Blacklist Adreno 3xx as it crashes on glBuffer(Sub)Data | ||
| const std::string renderer = reinterpret_cast<const char*>(glGetString(GL_RENDERER)); | ||
| if (renderer.find("Adreno (TM) 3") != std::string::npos) { |
There was a problem hiding this comment.
Can you make part of this check static? Its called on every every call to Context::createVertexArray()
- Causes crashes on usage of glBuffer(Sub)Data
ivovandongen
force-pushed
the
ivd-fix-motox
branch
from
b0ba488
to
f5130ca
Compare
|
Tested with: LG G Pad 8.3 | Adreno 320 ✅ |
|
Android 5.0 Moto X (2nd gen) | Adreno 330 |
@Guardiola31337 Are you sure you tested with this branch? I tested all of these on the same device without issues |
|
@Guardiola31337 did some follow up tests with an |
jfirebaugh
approved these changes
Oct 24, 2017
There was a problem hiding this comment.
opensciencemap/vtm#52 seems to corroborate the diagnosis of a bug in Adreno 3xx drivers with glBufferSubData and VAOs.
Guardiola31337
approved these changes
Oct 26, 2017
This was referenced Nov 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in the way we use vertex buffers introduced in #9009 causes crashes on usage of glBuffer(Sub)Data. This affects line placed text.
Relevant issues:
closes #10233