Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Don't request glyphs for verticalized punctuation if feature can't be verticalized #8982

Closed
mb12 opened this issue May 12, 2017 · 2 comments
Closed
Assignees
Labels
Core The cross-platform C++ core, aka mbgl text rendering

Comments

@mb12
Copy link

mb12 commented May 12, 2017

Platform:
iOS and Android
Mapbox SDK version:
Master

Steps to trigger behavior

For certain codepoints e.g. '.' , the corresponding verticalization char is also added to glyph dependencies. This happens here.

However the requested code point is not used if the placement is not along line. This happens here.

Expected behavior

Only request code point ranges that will be used during placement.

Actual behavior

@tobrun tobrun added the Core The cross-platform C++ core, aka mbgl label May 15, 2017
@ChrisLoer ChrisLoer changed the title Requested codepoint font range is not used during placement. Don't request glyphs for verticalized punctuation if feature can't be verticalized May 15, 2017
@ChrisLoer
Copy link
Contributor

It looks to me like fixing this just requires checking allowsVerticalWritingMode (and textAlongLine) for the feature before building the set of glyph dependencies.

/cc @1ec5

@jfirebaugh
Copy link
Contributor

Fixed in #9033.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl text rendering
Projects
None yet
Development

No branches or pull requests

4 participants