add support for multipolygons and polygon interior holes #1729

incanus · 2015-06-16T01:45:29Z

Punted from #1655. Will need to be exposed in MGLPolygon as well on iOS.

The text was updated successfully, but these errors were encountered:

jfirebaugh · 2015-12-15T01:27:41Z

GeoJSON sources support the full range of GeoJSON geometries. However if we want to continue expanding the annotations API, we could support this there too.

Zakay · 2015-12-15T08:01:48Z

+1 really need this!

TYRONEMICHAEL · 2016-01-22T09:01:01Z

+1

maciekish · 2016-02-10T15:32:36Z

+1

dariav · 2016-02-10T15:34:29Z

+1

MaximAlien · 2016-02-26T08:51:35Z

+1

aemchuk · 2016-02-26T09:07:03Z

+1 Will be very useful

caHarkness · 2016-04-29T00:42:25Z

We have switched from Google Maps to Mapbox (on Android) for the rendering speed of polygons, but this feature is essential. We absolutely need holes!

nealsanche · 2016-05-09T17:36:17Z

+1 I am currently working with a mapping app with very complex polygons with holes that Google Maps API is stumbling on quite profoundly. I'd dearly love to replace it with MapBox and then found out that holes are not currently supported. If I have to, I'd work to contribute a PR to the project so that this could be supported. Would you please contact me, so that I might be about to assess the work that might be involved in making that happen?

1ec5 · 2016-05-27T06:34:57Z

#5110 adds support for holes in polygons to the iOS and OS X SDKs. Note that, unlike in MapKit, a MGLPolygon cannot be nested more than one level deep; a concentric polygon, as it were, would be represented by an MGLMultiPolygon, which currently cannot be added to the map as a single annotation. True multipolygon support will have to wait for #5158.

MGLPolygon (and by extension MGLMultiPolygon) now supports interior rings. The data is preserved in feature querying results, and interior rings are respected when adding polygon overlays to the map. Fixes #1729. [ios, osx] Updated changelog

nealsanche · 2016-05-27T11:40:16Z

Last night I was able to render a polygon with holes on Android. Added the
API for adding holes to Java. Processed it in the JNI layer, and added
support in the rendering for the new data.

On Fri, May 27, 2016, 1:35 AM Minh Nguyễn [email protected] wrote:

#5110 #5110 adds support
for holes in polygons to the iOS and OS X SDKs. Note that, unlike in
MapKit, a MGLPolygon cannot be nested more than one level deep; a
concentric polygon, as it were, would be represented by an MGLMultiPolygon,
which currently cannot be added to the map as a single annotation. True
multipolygon support will have to wait for #5158
#5158.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#1729 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AFHsyc1aVVW4RDYPUcEFNYXJt4eMgfy2ks5qFpCagaJpZM4FD7gp
.

Robots and Pencils Inc | 1507 14th Ave SW Calgary AB T3C 0W4
You can unsubscribe from the Robots and Pencils mailing lists by clicking
here. https://robotsandpencils.com/contact/unsubscribe.html

1ec5 · 2016-05-27T14:35:00Z

That's great, @nealsanche! Would you mind posting a pull request so we can consider your changes?

nealsanche · 2016-05-27T15:04:55Z

Absolutely. I will do that this morning.

On Fri, May 27, 2016, 9:35 AM Minh Nguyễn [email protected] wrote:

That's great, @nealsanche https://github.com/nealsanche! Would you mind
posting a pull request so we can consider your changes?

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#1729 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AFHsyY136ktyyFXW4x3Bjdl8T5bnyJQxks5qFwEegaJpZM4FD7gp
.

Robots and Pencils Inc | 1507 14th Ave SW Calgary AB T3C 0W4
You can unsubscribe from the Robots and Pencils mailing lists by clicking
here. https://robotsandpencils.com/contact/unsubscribe.html

nealsanche · 2016-05-27T15:10:33Z

Okay, I've added a PR: #5170

nealsanche · 2016-05-27T15:14:07Z

Anyway, I'm sure after seeing that PR you'll want to re-implement it. But it gets me past the hurdle I was working though.

Screenshot

1ec5 · 2016-05-28T05:22:32Z

#5110 has been merged and is expected to be in iOS SDK v3.3.0-beta.1 and the next OS X SDK release. Leaving this issue open for Android.

jfirebaugh · 2016-06-02T00:56:55Z

Polygons, multipolygons, and multiline strings are supported by the core API as of #5200.

ivovandongen · 2016-08-16T15:19:28Z

~~Removed the current milestone as this requires breaking changes to the api~~ For now we will implement this without breaking changes

incanus · 2016-10-04T18:14:11Z

Just to clarify, we have interior hole support in iOS as of de905ab.

cvance · 2016-12-13T00:33:17Z

will this be fixed in 4.2.0?

1ec5 · 2016-12-13T07:14:55Z

No, this feature is now scheduled for v5.0.0, apparently with the expectation that adding support for multipolygons would be a breaking change.

Technically, polygon hole support could be added beforehand in v4.x (if there is another release between v4.2.0 and v5.0.0) without breaking backwards compatibility. getHoles() and setHoles() methods would be added to com.mapbox.mapboxsdk.annotations.Polygon, for compatibility with com.google.maps.model.Polygon. The underlying core support is already in place; it’s mostly a matter of plumbing through JNI.

paulVulog · 2017-03-22T15:27:01Z

@zugaldia Any update on it ? I was waiting for v5.0.0 to fixit but looks like it is no more the case...

1ec5 · 2017-03-22T16:45:35Z

#7397 is the latest attempt, but someone more familiar with Android than I will need to adopt it.

1ec5 · 2017-04-11T17:22:11Z

Fixed on Android in #8557.

incanus added the feature label Jun 16, 2015

incanus mentioned this issue Jun 16, 2015

shape annotations #1655

Closed

16 tasks

incanus mentioned this issue Sep 3, 2015

Add support for multipolygons and multipolylines #2245

Closed

1ec5 mentioned this issue Dec 14, 2015

No clear way for Polygon to support inner rings #3289

Closed

jfirebaugh changed the title ~~add support for polygon interior holes~~ add support for multipolygons and polygon interior holes Dec 15, 2015

jfirebaugh added iOS Mapbox Maps SDK for iOS Android Mapbox Maps SDK for Android labels Dec 15, 2015

antonino-u mentioned this issue Jan 25, 2016

Mapbox GL: Cannot show interior polygons prkng/ios#85

Open

1ec5 mentioned this issue Jan 29, 2016

Polygon Within Polygon, Shade everything except the intersection #3744

Closed

This was referenced May 23, 2016

Feature querying; more geometry types #5110

Merged

mbgl::AnnotationManager should use mapbox::geometry types #5158

Closed

1ec5 closed this as completed in de905ab May 28, 2016

1ec5 reopened this May 28, 2016

1ec5 added annotations Annotations on iOS and macOS or markers on Android and removed iOS Mapbox Maps SDK for iOS labels May 28, 2016

1ec5 added this to the android-v4.2.0 milestone Aug 15, 2016

tobrun assigned ivovandongen Aug 16, 2016

ivovandongen removed this from the android-v4.2.0 milestone Aug 16, 2016

ivovandongen added this to the android-v4.2.0 milestone Aug 16, 2016

zugaldia modified the milestones: android-future, android-v4.2.0 Sep 19, 2016

1ec5 mentioned this issue Dec 13, 2016

Polygon holes #7397

Closed

ivovandongen assigned Guardiola31337 and unassigned ivovandongen Mar 5, 2017

zugaldia removed this from the android-v5.0.0 milestone Mar 6, 2017

zugaldia added this to the android-future milestone Mar 23, 2017

Guardiola31337 mentioned this issue Mar 29, 2017

[android] Polygon holes #8557

Merged

9 tasks

tobrun modified the milestones: android-v5.1.0, android-future Apr 4, 2017

1ec5 closed this as completed Apr 11, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add support for multipolygons and polygon interior holes #1729

add support for multipolygons and polygon interior holes #1729

incanus commented Jun 16, 2015

jfirebaugh commented Dec 15, 2015

Zakay commented Dec 15, 2015

TYRONEMICHAEL commented Jan 22, 2016

maciekish commented Feb 10, 2016

dariav commented Feb 10, 2016

MaximAlien commented Feb 26, 2016

aemchuk commented Feb 26, 2016

caHarkness commented Apr 29, 2016 •

edited

Loading

nealsanche commented May 9, 2016

1ec5 commented May 27, 2016

nealsanche commented May 27, 2016

1ec5 commented May 27, 2016

nealsanche commented May 27, 2016

nealsanche commented May 27, 2016

nealsanche commented May 27, 2016

1ec5 commented May 28, 2016

jfirebaugh commented Jun 2, 2016 •

edited

Loading

ivovandongen commented Aug 16, 2016 •

edited

Loading

incanus commented Oct 4, 2016

cvance commented Dec 13, 2016 •

edited

Loading

1ec5 commented Dec 13, 2016 •

edited

Loading

paulVulog commented Mar 22, 2017

1ec5 commented Mar 22, 2017

1ec5 commented Apr 11, 2017

add support for multipolygons and polygon interior holes #1729

add support for multipolygons and polygon interior holes #1729

Comments

incanus commented Jun 16, 2015

jfirebaugh commented Dec 15, 2015

Zakay commented Dec 15, 2015

TYRONEMICHAEL commented Jan 22, 2016

maciekish commented Feb 10, 2016

dariav commented Feb 10, 2016

MaximAlien commented Feb 26, 2016

aemchuk commented Feb 26, 2016

caHarkness commented Apr 29, 2016 • edited Loading

nealsanche commented May 9, 2016

1ec5 commented May 27, 2016

nealsanche commented May 27, 2016

1ec5 commented May 27, 2016

nealsanche commented May 27, 2016

nealsanche commented May 27, 2016

nealsanche commented May 27, 2016

1ec5 commented May 28, 2016

jfirebaugh commented Jun 2, 2016 • edited Loading

ivovandongen commented Aug 16, 2016 • edited Loading

incanus commented Oct 4, 2016

cvance commented Dec 13, 2016 • edited Loading

1ec5 commented Dec 13, 2016 • edited Loading

paulVulog commented Mar 22, 2017

1ec5 commented Mar 22, 2017

1ec5 commented Apr 11, 2017

caHarkness commented Apr 29, 2016 •

edited

Loading

jfirebaugh commented Jun 2, 2016 •

edited

Loading

ivovandongen commented Aug 16, 2016 •

edited

Loading

cvance commented Dec 13, 2016 •

edited

Loading

1ec5 commented Dec 13, 2016 •

edited

Loading