This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Hard-code Null Island for runtime styling test #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relying on the stylesheet to jump from an invalid camera to Null Island seems to introduce a race condition where the tiles don’t render by the time the snapshot takes place.
This was referenced May 1, 2020
fabian-guerra
approved these changes
May 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relying on the stylesheet to jump from an invalid camera to Null Island seems to introduce a race condition in mbgl where the tiles don’t render by the time the snapshot takes place. Hard-coding the default camera as the snapshot’s camera merely makes the test failure less frequent on CI, but there is very likely an underlying issue: mapbox/mapbox-gl-native#16454.
Fixes #291.
/cc @mapbox/maps-ios