Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clusterMinPoints option for GeoJSONSource #9748

Merged
merged 2 commits into from
Jun 2, 2020
Merged

Add clusterMinPoints option for GeoJSONSource #9748

merged 2 commits into from
Jun 2, 2020

Conversation

mourner
Copy link
Member

@mourner mourner commented Jun 2, 2020 •
edited
Loading

Adds a clusterMinPoints option for clustered GeoJSON sources to define how many points are necessary to form a cluster (2 by default). Closes #6374. Actual implementation in mapbox/supercluster#156

Example with clusterMinPoints: 2 (default):
Screen Shot 2020-06-02 at 16 29 38
Example with clusterMinPoints: 3:
Screen Shot 2020-06-02 at 16 29 58

Launch Checklist

  • briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality (covered in supercluster)
  • document any changes to public APIs
  • manually test the debug page
  • tagged @mapbox/gl-native — PR needs a native port
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog:
<changelog>Added `clusterMinPoints` option for clustered GeoJSON sources that defines the minimum number of points to form a cluster.</changelog>

@mourner mourner requested a review from a team June 2, 2020 13:35
@mourner mourner mentioned this pull request Jun 2, 2020
Closed
ryanhamley
ryanhamley approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@ryanhamley ryanhamley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉

@ryanhamley ryanhamley merged commit 3ce4e9c into master Jun 2, 2020
@ryanhamley ryanhamley deleted the feature-cluster-min-points branch June 2, 2020 19:17
@sgolbabaei sgolbabaei mentioned this pull request Jun 9, 2020
Merged
sgolbabaei added a commit that referenced this pull request Jun 9, 2020
@sgolbabaei
Cherry pick (#9748) to release-erie
7a2b979
sgolbabaei added a commit that referenced this pull request Jun 10, 2020
@sgolbabaei
cherry picks from Master to Release-Erie (#9772)
8940417 
* Cherry pick (#9757) to release-erie

* Cherry pick (#9753) to release-erie

* Cherry pick (#9749) to release-erie

* Cherry pick (#9748) to release-erie
cowboyox pushed a commit to cowboyox/mapbox that referenced this pull request Oct 8, 2024
@sgolbabaei
cherry picks from Master to Release-Erie (#9772)
8ef30bc 
* Cherry pick (mapbox/mapbox-gl-js#9757) to release-erie

* Cherry pick (mapbox/mapbox-gl-js#9753) to release-erie

* Cherry pick (mapbox/mapbox-gl-js#9749) to release-erie

* Cherry pick (mapbox/mapbox-gl-js#9748) to release-erie
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanhamley ryanhamley ryanhamley approved these changes

Assignees
No one assigned
Labels
feature 🍏
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add clusterMinSize configuration
2 participants
@mourner @ryanhamley