v1.6.0 #9067
Merged
v1.6.0 #9067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chloekraw
reviewed
Dec 4, 2019
CHANGELOG.md
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| ## ✨ Features | |||
| * Add ability to insert images into text labels using a format expression: `"text-field": ["format", "Some text", ["image", "my-image"], "some more text"]` ([#8904](https://github.com/mapbox/mapbox-gl-js/pull/8904)) | |||
There was a problem hiding this comment.
using a format expression?
There was a problem hiding this comment.
would "using an image expression within a format expression" be better?
There was a problem hiding this comment.
Or were you talking about type of quotes?
There was a problem hiding this comment.
oh I was talking about the formatting. but I like your suggestion
chloekraw
reviewed
Dec 4, 2019
CHANGELOG.md
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| ## ✨ Features | |||
| * Add ability to insert images into text labels using a format expression: `"text-field": ["format", "Some text", ["image", "my-image"], "some more text"]` ([#8904](https://github.com/mapbox/mapbox-gl-js/pull/8904)) | |||
| * Add support for stretchable images (aka nine-patch images). Stretchable images can be used with `icon-text-fit` to draw resized images with unstretched corners and borders. ([#8997](https://github.com/mapbox/mapbox-gl-js/pull/8997)) | |||
| * Add support for stretchable images (aka nine-part or nine-patch images). Stretchable images can be used with `icon-text-fit` to draw resized images with unstretched corners and borders. ([#8997](https://github.com/mapbox/mapbox-gl-js/pull/8997)) | |||
| * Add "in" expression. It can check if a value is in an array (`["in", value, array]`) or a substring is in a string (`["in", substring, string]`) ([#8876](https://github.com/mapbox/mapbox-gl-js/pull/8876)) | |||
There was a problem hiding this comment.
however we format the "in" expression should match "format" above
nit: Add "in" expression, which can check if...
chloekraw
approved these changes
Dec 4, 2019
arindam1993
approved these changes
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.6.0
and style spec v13.10.0