Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8537
Fixes two
number-format
expression tests errors and addstest-expressions
to thetest-suite
script.number-format/currency
In node v10, ICU was updated in a way that changed behavior of
Intl.NumberFormat
. To fix the discrepancy in output fromIntl.NumberFormat
, switch to using a supported localeen-US
instead of specifyingja-JP
/de-DE
, which are not supported locales in default installations of node (with small-icu)number-format/precision
The expression tests stripped decimal precision when testing
number
type values indeepEqual
.mapbox-gl-js/test/integration/lib/expression.js
Lines 52 to 57 in a36fc99
This test is comparing string-ified number values, which does not strip precision. Since the test is validating that trailing
0
s are added, I reduced the precision of the input number so that rounding differences inIntl.NumberFormat
between node versions does not alter the test expectations.@mapbox/studio
and/or@mapbox/maps-design
if this PR includes style spec changes@mapbox/gl-native
if this PR includes shader changes or needs a native port