Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #8411, fetch in case of cache error #8415

Merged
merged 2 commits into from
Jul 1, 2019
Merged

fix #8411, fetch in case of cache error #8415

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a4381c
fix #8411, fetch in case of cache error
ansis Jun 30, 2019
31fa9ea
Use warnOnce
Jul 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/util/ajax.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// @flow

import window from './window';
import { extend } from './util';
import { extend, warnOnce } from './util';
import { isMapboxHTTPURL, hasCacheDefeatingSku } from './mapbox';
import config from './config';
import assert from 'assert';
Expand Down Expand Up @@ -111,7 +111,11 @@ function makeFetchRequest(requestParameters: RequestParameters, callback: Respon

const validateOrFetch = (err, cachedResponse, responseIsFresh) => {
if (err) {
return callback(err);
// Do fetch in case of cache error.
// HTTP pages in Edge trigger a security error that can be ignored.
if (err.message !== 'SecurityError') {
warnOnce(err);
}
}

if (cachedResponse && responseIsFresh) {
Expand Down