Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement diffing on style URLs #7562

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Implement diffing on style URLs #7562

merged 1 commit into from
Nov 8, 2018

Conversation

ryanhamley
Copy link
Contributor

@ryanhamley ryanhamley commented Nov 6, 2018 •
edited
Loading

Launch Checklist

Fixes #4025

  • briefly describe the changes in this PR
    • Previously, only styles that were passed to setStyle as JSON objects used smart diffing to avoid loading an entirely new style. This PR implements that same functionality for setStyle calls with a style URL.
  • document any changes to public APIs
  • manually test the debug page

TODO:

style-diff

@ryanhamley ryanhamley changed the title [WIP] Implement diffing on style URLs Implement diffing on style URLs Nov 8, 2018
mourner
mourner approved these changes Nov 8, 2018
View reviewed changes
Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 we can follow-up with glyph url diffing in a separate PR.

@ryanhamley ryanhamley merged commit 416f2a7 into master Nov 8, 2018
@ryanhamley ryanhamley deleted the style-diff-url branch November 8, 2018 19:15
@VictorVelarde VictorVelarde mentioned this pull request Jan 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanhamley @mourner