Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sprites wiggle around on scroll zoom because map.isZooming() always returns false due to the order of operations in the render loop, because it checks
ScrollZoomHandler.isActive()
which is set back to false by the time it is called heremapbox-gl-js/src/ui/map.js
Line 1634 in 61ae8d2
and
painter.options.zooming
is used to choose the texture filtermapbox-gl-js/src/render/draw_symbol.js
Lines 111 to 112 in e682aa6
I don't have many good ideas on how to test this 😬
Launch Checklist