Map class cleanup #7060
Merged
Map class cleanup #7060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfirebaugh
approved these changes
Aug 1, 2018
There was a problem hiding this comment.
LGTM. However I've always interpreted #2741 as being about the larger, API breaking change to make the runtime styling API more like native, where style and layer types are public and not everything needs to route through Map.
| @@ -1782,13 +1782,13 @@ test('Style#queryRenderedFeatures', (t) => { | |||
| style._updateSources(transform); | |||
|
|
|||
| t.test('returns feature type', (t) => { | |||
| const results = style.queryRenderedFeatures([{column: 1, row: 1, zoom: 1}], {}, transform); | |||
There was a problem hiding this comment.
First argument was supposed to be {viewport, worldCoordinate}, so apparently this was just working by accident before.
|
@jfirebaugh yeah, but that interpretation is only mentioned as a small comment at the bottom of the issue. So I think we should make a new issue focused on the API change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cleanup sweep for the
Mapclass. See individual commits. Fixes #2741. I don't think there's much more logic left to move downstream unless we break the API.Launch Checklist
document any changes to public APIspost benchmark scores