Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android-v6.3.0, ios-v4.2.0, macos-v0.9.0 in style spec #6988

Merged
merged 2 commits into from
Jul 19, 2018
Merged

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Jul 18, 2018

Updated the style specification compatibility tables to reflect mapbox/mapbox-gl-native#12176 mapbox/mapbox-gl-native#11869 mapbox/mapbox-gl-native#12329 in Android map SDK v6.3.0, iOS map SDK v4.2.0, and macOS map SDK v0.9.0.

/cc @ChrisLoer @mollymerp @friedbunny

@1ec5 1ec5 added the cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.) label Jul 18, 2018
@1ec5 1ec5 self-assigned this Jul 18, 2018
@1ec5 1ec5 requested review from ChrisLoer and mollymerp July 18, 2018 18:18
"collator": {
"js": "0.45.0",
"ios": "4.2.0",
"macos": "0.9.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisLoer, I think we should call out the collator syntax separately for each of these comparison operators, since it was introduced after the comparison operators themselves. Not sure if there need to be any changes in docs/pages/style-spec.js.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the component should be able to handle arbitrary rows already:

{entries(this.props).map(([key, entry], i) =>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this should work and I agree it makes sense to call out separately.

@1ec5 1ec5 changed the title ios-v4.2.0, macos-v0.9.0 in style spec android-v6.3.0, ios-v4.2.0, macos-v0.9.0 in style spec Jul 18, 2018
@@ -2983,6 +2990,11 @@
"android": "6.0.0",
"ios": "4.0.0",
"macos": "0.7.0"
},
"collator": {
"js": "0.45.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically Android map SDK v6.3.0 does support collators, but only in style JSON, not in the runtime styling API. Should I add it here anyways? Or perhaps add a separate row for runtime styling support?

/cc @tobrun

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would prefer leaving it out until we have a specific api for it in Expression.java (technically people can already use it with a raw expression).

@1ec5 1ec5 changed the base branch from master to mb-pages July 19, 2018 00:14
@1ec5 1ec5 merged commit 8abf008 into mb-pages Jul 19, 2018
@1ec5 1ec5 deleted the 1ec5-ios-v4.2.0 branch July 19, 2018 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants