don't fire click event if default is prevented on mousedown for a drag event #6697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6642
in #6218 we stopped checking if the mouse position had changed before firing a click event. the
DragPanHandler
suppresses its associatedclick
event onmouseup
mapbox-gl-js/src/ui/handler/drag_pan.js
Line 191 in a5a8dfe
but if
preventDefault()
is called onmousedown
the click was no longer being suppressed after a drag which caused the change in behavior in #6642I added a
drag
simulation that allows you to specify different options for mousedown/mouseup but I'm open to other ideas on how to test this.Launch Checklist