Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arbitrary states for feature interactivity #6263

Merged
merged 30 commits into from
Apr 26, 2018
Merged

Arbitrary states for feature interactivity #6263

merged 30 commits into from
Apr 26, 2018

Commits on Apr 19, 2018

  1. Track feature id to feature index in paint buffers.

    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    1fd379e View commit details
    Browse the repository at this point in the history

  2. Fix minor typo

    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    aafefb5 View commit details
    Browse the repository at this point in the history

  3. Implement state as properties

    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    d49d7f6 View commit details
    Browse the repository at this point in the history

  4. Update API args order and support retrieval of all states

    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    7cdd0dc View commit details
    Browse the repository at this point in the history

  5. Append state to features returned from queryRenderedFeatures

    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    03ba765 View commit details
    Browse the repository at this point in the history

  6. Support source-layers

    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    a25e350 View commit details
    Browse the repository at this point in the history

  7. Implement state expression

    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    5839647 View commit details
    Browse the repository at this point in the history

  8. Implement state dependenance

    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    3179d09 View commit details
    Browse the repository at this point in the history

  9. Move feature states management to SourceFeatureState. Fix typos, go w… 

    …ith the flow
    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    68666cc View commit details
    Browse the repository at this point in the history

  10. Only some layers in a bucket may have state dependency

    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    d395539 View commit details
    Browse the repository at this point in the history

  11. Support multiple symbol placements. Also inadvertently supports dupli… 

    …cate feature IDs :(
    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    25502f4 View commit details
    Browse the repository at this point in the history

  12. Add basic unit tests.

    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    28abe7e View commit details
    Browse the repository at this point in the history

  13. Address review feedback

    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    35c99ee View commit details
    Browse the repository at this point in the history

  14. Add feature-state render and query tests

    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    2ab766e View commit details
    Browse the repository at this point in the history

  15. Add points hover demo

    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    8643ce3 View commit details
    Browse the repository at this point in the history

  16. Rearrange and simplify arguments to Map#setfeatureState. Fire error f… 

    …or vector source without sourceLayer.
    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    6bb378c View commit details
    Browse the repository at this point in the history

  17. Fix this.needsUpload short-circuit, and make `Map#getFeatureState(...… 

    …key)` key argument required.
    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    d82ff17 View commit details
    Browse the repository at this point in the history

  18. Update feature state on symbols queried from a global collision index.

    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    9050725 View commit details
    Browse the repository at this point in the history

  19. Rename features state get/set to get(set)FeatureStateValue

    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    b3f8b97 View commit details
    Browse the repository at this point in the history

  20. Fix integration tests

    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    f6f4a20 View commit details
    Browse the repository at this point in the history

  21. Fix debug page and symbol querying

    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    d2887af View commit details
    Browse the repository at this point in the history

  22. Fix sourceLayer identification for geojson sources

    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    38bd87a View commit details
    Browse the repository at this point in the history

  23. Fix bug that affects first (0th) feature in every tile

    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    f78ab96 View commit details
    Browse the repository at this point in the history

  24. Rename 'state' expression to 'feature-state'. Add documentation in v8… 

    … spec and update debug page.
    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    b96b661 View commit details
    Browse the repository at this point in the history

  25. Separately signal upload and update for SybmolBuffer

    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    f3174e8 View commit details
    Browse the repository at this point in the history

  26. Rename setFatureStateValue to updateState. Allow setting/getting mult… 

    …iple properties.
    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    adcc01e View commit details
    Browse the repository at this point in the history

  27. Fix query integration tests.

    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    2721a29 View commit details
    Browse the repository at this point in the history

  28. Rename feature state setter to Map#setFeatureState. Update document… 

    …ation and tests.
    Asheem Mamoowala committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    ad5e67e View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2018

  1. Update highlightpoints.html to use setFeatureState

    @ChrisLoer
    ChrisLoer committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    9a2f755 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2018

  1. Add Feature states benchmark

    Asheem Mamoowala committed Apr 24, 2018
    Configuration menu
    Copy the full SHA
    2bde933 View commit details
    Browse the repository at this point in the history