Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for pitched and zoomed image source #5850

Merged
merged 1 commit into from
Dec 13, 2017
Merged

Add test for pitched and zoomed image source #5850

merged 1 commit into from
Dec 13, 2017

Conversation

asheemmamoowala
Copy link
Contributor

ChrisLoer
ChrisLoer approved these changes Dec 12, 2017
View reviewed changes
Copy link
Contributor

@ChrisLoer ChrisLoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really tell what's supposed to be happening in the expected.png, but I'll assume it's the correct behavior and gl-native currently fails on this test?

@asheemmamoowala
Copy link
Contributor Author

It's zoomed way in on the image. In native, without a fix, the image will not be displayed.

@asheemmamoowala asheemmamoowala merged commit cca8ba4 into master Dec 13, 2017
@asheemmamoowala asheemmamoowala deleted the pitched-image-source-test branch December 13, 2017 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisLoer ChrisLoer ChrisLoer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asheemmamoowala @ChrisLoer