Don't fire sourcedata event with sourceDataType: 'metadata' when a source is removed #5771
Conversation
jfirebaugh
force-pushed
the
styledata-events
branch
from
8543a5e
to
1b48fed
Compare
…urce is removed This event doesn't really make sense for this scenario; the metadata isn't changing. Instead, have the LogoControl listen for the styledata event that's triggered when a source is removed.
jfirebaugh
force-pushed
the
styledata-events
branch
from
1b48fed
to
31812da
Compare
There was a problem hiding this comment.
This change works for updating the logo control, but it changes the behavior of the attribution control when a source is removed. I think you'll have to add a listener for styledata on the AttributionControl as well to make sure removed sources don't continue to appear there.
| @@ -32,6 +32,7 @@ class LogoControl { | |||
| this._container.appendChild(anchor); | |||
| this._container.style.display = 'none'; | |||
|
|
|||
| this._map.on('styledata', this._updateLogo); | |||
There was a problem hiding this comment.
you'll also need to remove this event listener in the onRemove function
| @@ -32,6 +32,7 @@ class LogoControl { | |||
| this._container.appendChild(anchor); | |||
| this._container.style.display = 'none'; | |||
|
|
|||
| this._map.on('styledata', this._updateLogo); | |||
| this._map.on('sourcedata', this._updateLogo); | |||
There was a problem hiding this comment.
I think you are safe to remove this listener all together. Keeping it here and removing the metadata condition causes _updateLogo to be called on every tile load 🙃
There was a problem hiding this comment.
I think this might still be necessary to ensure that the control updates when TileJSON is loaded.
There was a problem hiding this comment.
good catch, thank you! it was working on the debug page because the spritesheet was loading after the tilejson.
jfirebaugh
force-pushed
the
styledata-events
branch
from
a3a47b1
to
564a53b
Compare
mollymerp
force-pushed
the
styledata-events
branch
from
564a53b
to
942753d
Compare
mollymerp
force-pushed
the
styledata-events
branch
from
942753d
to
d8a166f
Compare
|
Stale; closing for now. |
Noticed this while working on #5762 -- this was added in #4842, but it seems odd to me to fire this event when the source itself isn't changing. Instead, have the LogoControl listen for the styledata event that's triggered when a source is removed.