Refactor fill extrusion texture/fbo cache #5328
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lbud @jfirebaugh this is just a quick exploration of how caching textures in style layer objects would look. I would highly benefit from something like this in #5253 because I need to cache two types of textures that differ from the fill extrusion use case — a half-float screen-sized texture downscaled by 4, and a 256x1 RGBA color ramp texture.
Heatmap-specific caching logic in
painter.js
would look really bad, and while I agree it's awkward to cache render-specific stuff in style layers and look forward toRenderLayer
-introducing refactor, for now this seems like a lesser evil than writing lots of layer-specific code inpainter.js
.Launch Checklist
write tests for all new functionality(covered by render tests)document any changes to public APIspost benchmark scoresthere are no benchmarks with extrusions