Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support expressions in filters #5193

Closed
wants to merge 7 commits into from
Closed

Support expressions in filters #5193

wants to merge 7 commits into from

Commits on Oct 9, 2017

  1. Add a method to distinguish filter expressions from old-style filters

    @jfirebaugh
    jfirebaugh committed Oct 9, 2017
    Configuration menu
    Copy the full SHA
    c0aa1be View commit details
    Browse the repository at this point in the history

  2. Accept {zoom} as first argument to filter function 

    Prepares for expression support
    @jfirebaugh
    Anand Thakker authored and jfirebaugh committed Oct 9, 2017
    Configuration menu
    Copy the full SHA
    3bce29b View commit details
    Browse the repository at this point in the history

  3. Support expressions in filters 

     - Converts classic filters to expressions under the hood
 - Also accepts `{expression: [...]}`, requiring that the given
 expression be of type Boolean
    @jfirebaugh
    Anand Thakker authored and jfirebaugh committed Oct 9, 2017
    Configuration menu
    Copy the full SHA
    7f0d163 View commit details
    Browse the repository at this point in the history

  4. reduce → loops

    @jfirebaugh
    jfirebaugh committed Oct 9, 2017
    Configuration menu
    Copy the full SHA
    9912ce1 View commit details
    Browse the repository at this point in the history

  5. Specialize boolean ops for 2 args

    @jfirebaugh
    jfirebaugh committed Oct 9, 2017
    Configuration menu
    Copy the full SHA
    0a46e20 View commit details
    Browse the repository at this point in the history

  6. Add specialized filter expression forms

    @jfirebaugh
    jfirebaugh committed Oct 9, 2017
    Configuration menu
    Copy the full SHA
    d7e7681 View commit details
    Browse the repository at this point in the history

  7. Direct CompoundExpression evaluation

    @jfirebaugh
    jfirebaugh committed Oct 9, 2017
    Configuration menu
    Copy the full SHA
    29a84cb View commit details
    Browse the repository at this point in the history