Move ignores/skips to independent files #4977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfirebaugh
force-pushed
the
local-ignores
branch
3 times, most recently
from
4940695
to
fe65765
Compare
anandthakker
approved these changes
Jul 12, 2017
test/integration/generate-ignores.js
Outdated
|
|
||
| fs.writeFileSync('ignores-native.json', JSON.stringify(native, null, 2)); | ||
| fs.writeFileSync('ignores-js.json', JSON.stringify(js, null, 2)); | ||
| }); |
There was a problem hiding this comment.
Do we need this script, now that the ignores files exist?
There was a problem hiding this comment.
I might need to run it again if the files changes before this PR merges, but I'll remove it before merging.
jfirebaugh
force-pushed
the
local-ignores
branch
from
f6f313d
to
83c7fc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to separate
ignores.jsonfiles in mapbox-gl-native and mapbox-gl-js for ignoring or skipping integration tests.This PR contains the gl-js side; gl-native side is in mapbox/mapbox-gl-native#9490.
cc @mapbox/gl