Type browser #4909
Merged
Type browser #4909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandthakker
approved these changes
Jun 30, 2017
src/util/browser.js
Outdated
| return window.performance.now.bind(window.performance); | ||
| } else { | ||
| return Date.now.bind(Date); | ||
| } |
There was a problem hiding this comment.
Why use the immediately invoked function expression (IIFE) here (and below in frame, cancelFrame) rather than declaring const now = (window.performance && window.performance.now) ? window.performance.now.bind(window.performance) : Date.now.bind(Date); prior to defining the exported object?
No strong objection to this, but all else being equal, I think IIFE is maybe a bit less readable.
There was a problem hiding this comment.
Keeps the initialization scoped to the relevant property and avoids extra variables at module scope. Although, given that other parts of the module want to use now, frame, etc., it probably is better to have local variables. I'll change this.
Switched to object literal so we can use `get` rather than `Object.defineProperty`. Add @module declaration to util.js to work around a documentation.js bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getrather thanObject.defineProperty.@moduledeclaration to util.js to work around a documentation.js bug.