add map.getMaxBounds method #4890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Credit to @lamuertepeluda which provided some of the basis to this commit at #4029 (comment)
andrewharvey
force-pushed
the
getMaxBounds
branch
from
f887a32
to
cb7ed47
Compare
mollymerp
reviewed
Jun 26, 2017
There was a problem hiding this comment.
🙏 thanks @andrewharvey! just a small change but otherwise this looks good to me!
src/ui/map.js
Outdated
| * @returns {LngLatBounds | null} The maximum bounds the map is constrained to, or `null` if none set. | ||
| */ | ||
| getMaxBounds () { | ||
| if (!(!Array.isArray(this.transform.latRange) || this.transform.latRange.length === 0) && |
There was a problem hiding this comment.
I find this a little hard to read 😕 can we invert the check ( if (this.transform.latRange && this.transform.latRange.length == 2) && ... else { return null; } ) for clarity?
| @@ -434,6 +450,7 @@ class Map extends Camera { | |||
| return this; | |||
|
|
|||
| } | |||
|
|
|||
There was a problem hiding this comment.
everywhere else had a whitespace between methods, so I added one here to be consistent.
andrewharvey
force-pushed
the
getMaxBounds
branch
from
9d80e41
to
07cc291
Compare
|
should be good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
part of #4029
Thanks to @lamuertepeluda for the inspiration in #4029 (comment)