Use gl.pixelStorei to premultiply alphas on icons and images in SpriteAtlas #4644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfirebaugh
reviewed
Apr 26, 2017
src/symbol/sprite_atlas.js
Outdated
| @@ -61,6 +61,8 @@ class SpriteAtlas extends Evented { | |||
|
|
|||
| if (ArrayBuffer.isView(pixels)) { | |||
| pixels = new Uint32Array(pixels.buffer); | |||
| } else if (pixels.data) { //Support ImageData correctly | |||
There was a problem hiding this comment.
Any particular reason to add this? We don't document Map#addImage as accepting ImageData.
There was a problem hiding this comment.
You're right, it isn't documented. I was thrown off by the error message at Line 67 below
added 2 commits
April 25, 2017 17:56
kkaefer
reviewed
Apr 26, 2017
| @@ -221,6 +221,7 @@ class SpriteAtlas extends Evented { | |||
| gl.bindTexture(gl.TEXTURE_2D, this.texture); | |||
| gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_WRAP_S, gl.CLAMP_TO_EDGE); | |||
| gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_WRAP_T, gl.CLAMP_TO_EDGE); | |||
| gl.pixelStorei(gl.UNPACK_PREMULTIPLY_ALPHA_WEBGL, true); | |||
jfirebaugh
approved these changes
Apr 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #4534
Images and Icons added to the SpriteAtlas need to premultiply the alpha channel in the image data to improve alpha blending. This is now done using WebGLs built-in flag for unpacking image data in textures
Launch Checklist
document any changes to public APIs