Handle |latitude| > 85.05113 in ImageSource #4574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #4573 The issue here was that `util.getCoordinatesCenter`, in addition to finding the center of the given coordinates on the x-y plane, also attempts to choose the largest zoom level where one tile would cover the area spanned by the given points. Since latitudes outside of [-85.05113, 85.05113] don't fit even on z0, we would get a negative zoom value.
jfirebaugh
approved these changes
Apr 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4573
The issue here was that
util.getCoordinatesCenter, in addition to finding the center of the given coordinates on the x-y plane, also attempts to choose the largest zoom level where one tile would cover the area spanned by the given points. Since latitudes outside of [-85.05113, 85.05113] don't fit even on z0, we would get a negative zoom value, which later violated assertions inTileCoord()