Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix boxZoom bug #4528

Merged
merged 2 commits into from
Apr 18, 2017
Merged

fix boxZoom bug #4528

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d4f4d7
fix boxZoom bug
Apr 1, 2017
d4230aa
actually fix the :bug:
Apr 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/ui/handler/box_zoom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,14 @@ class BoxZoomHandler {
*/
enable() {
if (this.isEnabled()) return;

// the event listeners for the DragPanHandler have to fire _after_ the event listener for BoxZoomHandler in order,
// for the DragPanHandler's check on map.boxZoom.isActive() to tell whether or not to ignore a keydown event
// so this makes sure the firing order is preserved if the BoxZoomHandler is enabled after the DragPanHandler.
if (this._map.dragPan) this._map.dragPan.disable();
this._el.addEventListener('mousedown', this._onMouseDown, false);
if (this._map.dragPan) this._map.dragPan.enable();

this._enabled = true;
}

Expand Down