Enable property functions for text-field, text-transform #4074
Conversation
| "type": "categorical", | ||
| "property": "x", | ||
| "stops": [ | ||
| [0, "Zero {units}"], |
There was a problem hiding this comment.
I am not sure we want to allow the combination of data-driven properties and interpolation syntax. It could further complicate the future of features like mapbox/mapbox-gl-style-spec#47 and mapbox/mapbox-gl-style-spec#104.
There was a problem hiding this comment.
👍 agreed -- updated to resolve tokens only when text-field is 'feature constant'
|
There was a problem hiding this comment.
Make the render tests as simple as possible:
- Render at 0/0/0, and as small as 64x64 if possible
- Simple GeoJSON coordinates like
[-10, 0] - Don't include a background layer -- transparent is fine
- Cite Port data-driven styling (property functions) from GL JS mapbox-gl-native#4860 as the native issue
|
@jfirebaugh updated |
@jfirebaugh sounds like fun 😄 . Do you think it makes sense for me to first work through #4186 (enabling DDS for the first couple symbol paint properties)? |
|
No, I would port this first. Should be fairly straightforward (knock on wood). The issues in #4186 are thornier and may take some time to work out. |
* Enable property functions for text-field, text-transform
* Do not perform text-field token replacement on property functions
* Add test for text-field token replacement
* Skip text-{field,transform} property function tests on native
* Update resolve_text test
* Simplify render tests
Launch Checklist
data-driven stylingsupport matrix for these properties, since we don't know what version this will go out in.