Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression #4054: use new ajax.getArrayBuffer interface for rtl-text #4055

Merged
merged 1 commit into from
Jan 26, 2017

Conversation

ChrisLoer
Copy link
Contributor

There's still no automated testing covering the asynchronous load (because we don't want automated tests dependent on any network interaction). Do we have mocks that would be useful here?

@1ec5 1ec5 added the bug 🐞 label Jan 26, 2017
@lucaswoj
Copy link
Contributor

Do we have mocks that would be useful here?

First thing that comes to mind: we could use Sinon's "fake" XMLHttpRequest mock as we do in some unit tests http://sinonjs.org/docs/#server

@anandthakker
Copy link
Contributor

we could use Sinon's "fake" XMLHttpRequest mock

👍 to that -- we technically could use proxyquire to mock the js/util/ajax module, but that doesn't guard against ajax's interface changing, as in this case.

@lucaswoj lucaswoj merged commit 17fa667 into master Jan 26, 2017
@lucaswoj lucaswoj deleted the cloer-4054-regression branch January 26, 2017 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants