add "Map#isMoving" method #2792 #3941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 10, 2017
lucaswoj
reviewed
Jan 18, 2017
| this.on('moveend', () => { | ||
| this.animationLoop.set(300); // text fading | ||
| this._rerender(); | ||
| this._isMoving = false; |
There was a problem hiding this comment.
There are already a few places we store this state in Camera. I'd prefer to avoid adding a new one, especially on Map. We are trying to move towards making Map more simple: #2741
Camera#_finishFnwould be a drop-in replacement forMap#_isMovingCamera#panning,Camera#pitching, andCamera#zoomingare in the spirit ofMap#_isMoving, should we addCamera#panningorCamera#moving?)
There was a problem hiding this comment.
So we should move Map#isMoving to Camera#isMoving? And add Camera#moving and Camera#panning similarly to Camera#rotating, Camera#pitching, and Camera#zooming?
lucaswoj
approved these changes
Jan 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Map#isMovingmethod according to #2792