Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run nyc with cache on #3161

Merged
merged 1 commit into from
Sep 8, 2016
Merged

Run nyc with cache on #3161

merged 1 commit into from
Sep 8, 2016

Conversation

mourner
Copy link
Member

@mourner mourner commented Sep 8, 2016

Cuts down the CI build by ~2 minutes. Doesn't affect render/query tests but brings down unit test coverage from 3m to 1m — apparently the same files were instrumented over and over before without this setting.

--cache was considered to be enabled by default in nyc, but it was left off (istanbuljs/nyc#303) because of some weird ava+babel+nyc conflicts.

cc @jfirebaugh @lucaswoj

@mourner mourner merged commit 49abc8e into master Sep 8, 2016
@mourner mourner deleted the cache-nyc branch September 8, 2016 10:25
@mourner mourner mentioned this pull request Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant