Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fill-opacity overlapping test-suite test #2793

Merged
merged 6 commits into from
Jun 29, 2016
Merged

Conversation

lucaswoj
Copy link
Contributor

@lucaswoj
Copy link
Contributor Author

Blocked on merging this by some failing test-suite cases that have been added since the last GL JS sync

@lucaswoj
Copy link
Contributor Author

Failing test cases:

  • layout-property-function-to-default
  • layout-property-function-to-literal
  • layout-property-literal-to-default
  • layout-property-literal-to-function
  • paint-property-function-to-default

@jfirebaugh
Copy link
Contributor

jfirebaugh commented Jun 29, 2016

@lucaswoj Those are tests I added and I believe the failures are indications of bugs in gl-js. Do you want me to file tickets and disable them for now, or are you on the case?

@lucaswoj
Copy link
Contributor Author

Disabling tests doesn't allow test-suite to pass in the case of runtime exceptions (this case). I'm going to make some changes to the test-suite harness and fix these bugs first thing tomorrow.

@jfirebaugh
Copy link
Contributor

Disabling with "js": false (rather than "ignored": {...}) will prevent the test from running entirely.

@lucaswoj lucaswoj merged commit c698a56 into master Jun 29, 2016
@lucaswoj lucaswoj deleted the fill-opacity-overlapping branch June 29, 2016 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants