Fire mouseout events #2777
Merged
Fire mouseout events #2777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps hide popups / highlighted areas which can clutter the screen, on a mouse out
|
Great! Thanks @alcoheca! |
| @@ -37,6 +38,11 @@ module.exports = function bindHandlers(map, options) { | |||
| el.addEventListener('dblclick', onDblClick, false); | |||
| el.addEventListener('contextmenu', onContextMenu, false); | |||
|
|
|||
| function onMouseOut(e) { | |||
| map.stop(); | |||
There was a problem hiding this comment.
Let's remove this line. By default, animated zooms/pans should not stop if the cursor leaves the canvas.
There was a problem hiding this comment.
sorry - I'll be honest i wasn't 100% about this line..
should I do anything?
alcoheca
added a commit
to alcoheca/mapbox-gl-js
that referenced
this pull request
Jun 27, 2016
lucaswoj
pushed a commit
that referenced
this pull request
Jun 27, 2016
This was referenced Jul 1, 2016
davidtheclark
pushed a commit
that referenced
this pull request
Jul 1, 2016
Helps hide popups / highlighted areas which can clutter the screen, on a mouse out
davidtheclark
pushed a commit
that referenced
this pull request
Jul 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows developers to hide popups / clear highlighted areas which can clutter the screen after the user moves the mouse pointer out of context.