Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transitions for *-translate properties #2771

Closed
wants to merge 2 commits into from
Closed

Fix transitions for *-translate properties #2771

wants to merge 2 commits into from

Conversation

jfirebaugh
Copy link
Contributor

Fixes #2762, see #2762 (comment) for details.

Setting a 0-duration transition doesn't work for testing this bug, because it short circuits the code that was at fault. So in order for this to be testable in the test suite, we need to tackle mapbox/mapbox-gl-test-suite#116. I'm going to look into that next.

@jfirebaugh
Copy link
Contributor Author

So in order for this to be testable in the test suite, we need to tackle mapbox/mapbox-gl-test-suite#116. I'm going to look into that next.

This looks like it will require significant refactoring. There are a number of internals which use Date.now() directly that need to be converted to using a passed in parameter.

@jfirebaugh jfirebaugh closed this Jun 21, 2016
@jfirebaugh jfirebaugh deleted the 2762 branch June 21, 2016 20:34
@jfirebaugh
Copy link
Contributor Author

Cherry picked for v0.20.1 patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant