Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Map#load" fire, even if "Not Found" errors were encountered #2176

Merged
merged 1 commit into from
Feb 23, 2016

Conversation

lucaswoj
Copy link
Contributor

ref #1985
ref #1800

If a vector tile request gets a 404 response, the Map#load event doesn't fire.
#1800 is about a feature request that is different than this bug but the two have been conflated.

cc @jfirebaugh @ansis @geografa @laurenancona

@ansis
Copy link
Contributor

ansis commented Feb 23, 2016

looks good to me

@superphly
Copy link

So by setting tile.errored = true;, that allows the map#load to fire?

@lucaswoj
Copy link
Contributor Author

@superphly Correct. To understand why, take a look at the TilePyramid#loaded method https://github.com/mapbox/mapbox-gl-js/blob/master/js/source/tile_pyramid.js#L49

@laurenancona
Copy link

\o/

Thanks, @lucaswoj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants