implement symbol-avoid-edges #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansis
force-pushed
the
symbol-avoid-edges
branch
from
0e6a21e
to
a490ee6
Compare
|
@lucaswoj can you review? |
| // But the label can be shown after this box is not visible. | ||
| collisionFreeScale = box.maxScale; | ||
| } | ||
| CollisionTile.prototype.checkForCollision = function(minPlacementScale, anchorPoint, box, blockingAnchorPoint, blocking) { |
There was a problem hiding this comment.
Would it make more sense for this method to be called findEdgeMinPlacementScale?
There was a problem hiding this comment.
I suppose keeping these method names as similar as possible to those in native is most important.
|
Looks 👍 overall. Ready to ship once minor comments are addressed. |
if `symbol-avoid-edges` is true, this prevents symbols from colliding with tile edges.
ansis
force-pushed
the
symbol-avoid-edges
branch
from
a490ee6
to
f023f65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent symbols from colliding with tile edges when
symbol-avoid-edgesis true.ref mapbox/mapbox-gl-native#3582
render tests: mapbox/mapbox-gl-test-suite@bc0272c