Fix unstable symbol rendering order #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We also do a |
|
Doing a for-in over bucketsById is ok as long as the resulting arrays are treated like sets instead of ordered arrays. |
|
|
||
| for (var id in this._layers) { | ||
| ordered.push(this._layers[id].json()); | ||
| } |
There was a problem hiding this comment.
While not in the official spec, all major JS interpreters will iterate over objects in the order that the keys were added.
If a call to addLayer specifies a before parameter, it'll end up at the end of this array, even though it was intended for elsewhere. Then, during label placement in the worker, the layer will not be ordered correctly, leading to the "unstable symbol layer order" bug.
|
Using _order looks safe to me. 👍 |
|
Good catch. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of the layers we pass to
WorkerTileis related to the order that they were added to the stylesheet, not their logical order.fixes #1558
cc @scothis @samanpwbb