Adding special case for non-fontstack "glyph" resource URLs #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- does not prepend /v4/ to api endpoints like /fonts/v1/ - only prepends it to things starting with /fontstack - solves the problem in #1385 - refs mapbox/mapbox-gl-style-spec#309
|
👍 |
|
Hmm, why did you merge and then revert the commit in master? |
|
@mourner I accidentally pushed to master at first. Figured it was best to revert and then create a separate pull request. Felt safer than |
|
Eh, can't rebase/merge it properly now since master already contains the commit... Will do a button merge then. |
mourner
added a commit
that referenced
this pull request
Jul 24, 2015
Adding special case for non-fontstack "glyph" resource URLs
|
thanks @mourner!! Sorry about the slip up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc/ @samanpwbb @mikemorris @mourner @tmcw