Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pausing with the mousedown while panning prevents any further panning (0.44.0) #6063

Closed
joedjc opened this issue Jan 26, 2018 · 1 comment
Closed

Pausing with the mousedown while panning prevents any further panning (0.44.0) #6063

joedjc opened this issue Jan 26, 2018 · 1 comment

Comments

@joedjc
Copy link

joedjc commented Jan 26, 2018 •
edited
Loading

Hi,

I'm noticing an issue after upgrading to 0.44.0. Took a while to work out what was going on but I believe it is the following:

v0.44.0

Steps to Trigger Behavior

  1. Start panning around the map
  2. Stop/pause panning for a moment, but keep holding down the mouse button
  3. Move the mouse to start panning again

Expected Behavior

Panning should continue after the pause if the user is still holding the mouse button down without having to let go.

Actual Behavior

The map does not continue to pan (and appears frozen) until the user stops panning (let go of the mouse button) then starts again.

It can look like the map randomly freezes if the user happens to pause for a moment e.g. they pan left, pause, then pan right.

I've tested this in Chrome, Safari and Edge on a couple of computers. I was able to replicate using the mapbox examples.

Thanks,
Joe
anandthakker pushed a commit that referenced this issue Jan 26, 2018
Ensure drag handlers request render frames on move
de8a4f3 
Closes #6063

Caused by #6005 because,
after that change, the drag handlers relied on the `move` event to
trigger a map rerender to pick up the next batch of mouse movements.

This worked fine while dragging was in progress, but after the user
paused and the render frame triggered by the last `move` event was
complete, there was nothing to re-initiate the render loop once the
mouse moved again.
@anandthakker anandthakker mentioned this issue Jan 26, 2018
Merged
3 tasks
@anandthakker
Copy link
Contributor

Thanks for the report @joedjc! Fix pending in #6068

anandthakker added a commit that referenced this issue Jan 27, 2018
@anandthakker
Ensure drag handlers request render frames on move (#6068)
6600374 
Closes #6063

Caused by #6005 because,
after that change, the drag handlers relied on the `move` event to
trigger a map rerender to pick up the next batch of mouse movements.

This worked fine while dragging was in progress, but after the user
paused and the render frame triggered by the last `move` event was
complete, there was nothing to re-initiate the render loop once the
mouse moved again.
@pathmapper pathmapper mentioned this issue Jan 28, 2018
Closed
@anandthakker anandthakker mentioned this issue Jan 28, 2018
Merged
@ttsirkia ttsirkia mentioned this issue Jan 30, 2018
Closed
pathmapper pushed a commit to pathmapper/mapbox-gl-js that referenced this issue Feb 13, 2018
@anandthakker
Ensure drag handlers request render frames on move (mapbox#6068) (map…
cba52f9 
…box#6073)

Closes mapbox#6063

Caused by mapbox#6005 because,
after that change, the drag handlers relied on the `move` event to
trigger a map rerender to pick up the next batch of mouse movements.

This worked fine while dragging was in progress, but after the user
paused and the render frame triggered by the last `move` event was
complete, there was nothing to re-initiate the render loop once the
mouse moved again.
pathmapper pushed a commit to pathmapper/mapbox-gl-js that referenced this issue Feb 13, 2018
@anandthakker
Ensure drag handlers request render frames on move (mapbox#6068) (map…
c15f638 
…box#6073)

Closes mapbox#6063

Caused by mapbox#6005 because,
after that change, the drag handlers relied on the `move` event to
trigger a map rerender to pick up the next batch of mouse movements.

This worked fine while dragging was in progress, but after the user
paused and the render frame triggered by the last `move` event was
complete, there was nothing to re-initiate the render loop once the
mouse moved again.
@corradio corradio mentioned this issue Feb 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anandthakker @joedjc