Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make adding GeoJSON easier (skipping style modifications) #327

Closed
mourner opened this issue Mar 14, 2014 · 3 comments
Closed

Make adding GeoJSON easier (skipping style modifications) #327

mourner opened this issue Mar 14, 2014 · 3 comments

Comments

@mourner
Copy link
Member

mourner commented Mar 14, 2014

Make it dead easy to add GeoJSON data to LLMR without forcing the user to set up buckets/structure/styles etc. Maybe set up default ones for cases when GeoJSON id is not specified.

@mourner mourner added the api label Mar 14, 2014
@mourner mourner added this to the future milestone Jun 24, 2014
@jfirebaugh
Copy link
Contributor

Good use case to cover: GeoJSON under labels.

@jfirebaugh
Copy link
Contributor

I'm pretty happy with the current gl-js API:

map.addSource('geojson', {
"type": "geojson",
"data": "/debug/route.json"
});
map.addLayer({
"id": "route",
"type": "line",
"source": "geojson",
"paint": {
"line-color": "#EC8D8D",
"line-width": "@motorway_width"
}
}, 'country_label_1');
.

The last thing I think we should do here is add a placeholder layer with id labels to all the example styles that doesn't render anything but can be used to do map.addLayer({...}, "labels").

@mourner
Copy link
Member Author

mourner commented Mar 1, 2015

Yeah, looks pretty good now.

@mourner mourner closed this as completed Mar 1, 2015
bensleveritt pushed a commit to bensleveritt/mapbox-gl-js that referenced this issue Oct 24, 2016
lucaswoj added a commit that referenced this issue Jan 11, 2017
Removed duplicate circle layout properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants