Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setPaintProperty should be a noop if given the same value #2362

Closed
mourner opened this issue Mar 30, 2016 · 0 comments
Closed

setPaintProperty should be a noop if given the same value #2362

mourner opened this issue Mar 30, 2016 · 0 comments
Labels
performance ⚡ Speed, stability, CPU usage, memory usage, or power usage

Comments

@mourner
Copy link
Member

mourner commented Mar 30, 2016

Unlike all other style setters, setPaintProperty doesn't check whether it's given the same value that it already has, so it can do unnecessary work. Ref #2334 (comment)
@mourner mourner added the performance ⚡ Speed, stability, CPU usage, memory usage, or power usage label Mar 30, 2016
mourner added a commit that referenced this issue Mar 30, 2016
@mourner
don't do anything on noop setPaintProperty
a2698a9 
Closes #2362
@mourner mourner mentioned this issue Mar 30, 2016
Merged
mourner added a commit that referenced this issue Mar 30, 2016
@mourner
don't do anything on noop setPaintProperty
3e443c7 
Closes #2362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance ⚡ Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mourner