filterEmptyBuckets breaks reloadSymbolData

[ansis]

mapbox-gl-js/js/source/worker_tile.js

Line 191 in 352eb64

buckets = filterEmptyBuckets(buckets);

mapbox-gl-js/js/source/tile.js

Line 97 in 352eb64

oldBucket.destroy(painter.gl);

oldBucket is undefined if the bucket used to be empty and was filtered out by filterEmptyBuckets. Trying to call destroy on undefined will error.

If a bucket is filtered out in the current set of results but was present in the last one, it won't get removed from this.buckets and we will render stale symbols.

cc @lucaswoj

[lucaswoj]

My fault. I even left this helpful comment. 😬

// TODO rewrite this

[lucaswoj]

I'm not sure how to trigger an error using this fault. Can you make a demo using this jsbin @ansis? http://jsbin.com/kavitapesi/1/edit?html,output