-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filterEmptyBuckets breaks reloadSymbolData #2244
Labels
Comments
My fault. I even left this helpful comment. 😬
|
I'm not sure how to trigger an error using this fault. Can you make a demo using this jsbin @ansis? http://jsbin.com/kavitapesi/1/edit?html,output |
lucaswoj
pushed a commit
that referenced
this issue
Mar 11, 2016
lucaswoj
pushed a commit
that referenced
this issue
Mar 14, 2016
lucaswoj
pushed a commit
that referenced
this issue
Mar 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mapbox-gl-js/js/source/worker_tile.js
Line 191 in 352eb64
mapbox-gl-js/js/source/tile.js
Line 97 in 352eb64
oldBucket
is undefined if the bucket used to be empty and was filtered out byfilterEmptyBuckets
. Trying to call destroy on undefined will error.If a bucket is filtered out in the current set of results but was present in the last one, it won't get removed from
this.buckets
and we will render stale symbols.cc @lucaswoj
The text was updated successfully, but these errors were encountered: