Right-clicking on map does not fire 'click' event

[misterfresh]

also related to #1405

[mourner]

Most mapping libraries including Leaflet don't fire click on right click — only on left click. Instead, right click fires a separate contextmenu event (already supported in GL JS). I believe we should follow the same convention here instead of c5fc748. @bhousel @jfirebaugh

[misterfresh]

I wanted to get a behavior where if I left-click on the map, it adds a
marker, and if I right-click on a marker, it removes it from the map.

Le mer. 7 oct. 2015 à 08:22, Vladimir Agafonkin [email protected]
a écrit :

Most mapping libraries including Leaflet don't fire click on right click —
only on left click. Instead, right click fires a separate contextmenu
event (already supported in GL JS). I believe we should follow the same
convention here instead of c5fc748
c5fc748.
@bhousel https://github.com/bhousel @jfirebaugh
https://github.com/jfirebaugh

—
Reply to this email directly or view it on GitHub
#1416 (comment)
.

[mourner]

@misterfresh that's a perfect use case for separate events (click for adding marker, contextmenu for removing it).

[bhousel]

I agree that we should generally just pass the DOM events as-is to the user.

@misterfresh, I'll back out the change in c5fc748, but you can look at that for how to implement a right (or middle) click event by using mousedown and mouseup events and keeping track of the buttons that were pressed and their coordinates.

[misterfresh]

Interesting, thanks.

2015-10-07 14:14 GMT+02:00 Bryan Housel [email protected]:

I agree that we should generally just pass the DOM events as-is to the
user.

@misterfresh https://github.com/misterfresh, I'll back out the change
in c5fc748
c5fc748,
but you can look at that for how to implement a right (or middle) click
event by using mousedown and mouseup events and keeping track of the
buttons that were pressed and their coordinates.

—
Reply to this email directly or view it on GitHub
#1416 (comment)
.