Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nullable motion events #101

Merged
merged 9 commits into from
Aug 19, 2022
Merged

Fix nullable motion events #101

merged 9 commits into from
Aug 19, 2022

Conversation

yunikkk
Copy link
Contributor

@yunikkk yunikkk commented Aug 18, 2022

Also bumped dependencies and used Maps v10 in the test app

Original ticket - #101

@@ -1,5 +1,9 @@
# Changelog for the Mapbox Gestures for Android

## 0.8.0 -
#### Breaking changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also update readme for the repo with instructions how to setup Maps SDK v10?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gradle/dependencies.gradle Outdated Show resolved Hide resolved
@pengdev
Copy link
Member

pengdev commented Aug 18, 2022

Shall we validate the NonNull annotations for all the changes introduced in #95 ? it might apply to other gesture detector overwrites as well.

}
credentials {
username = "mapbox"
password = System.getenv("SDK_REGISTRY_TOKEN") ?: project.property("SDK_REGISTRY_TOKEN") as String
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add installation instructions to readme? There's already a small section about the token that will have to get refactored now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG.md Outdated Show resolved Hide resolved
@yunikkk
Copy link
Contributor Author

yunikkk commented Aug 18, 2022

Shall we validate the NonNull annotations for all the changes introduced in #95 ? it might apply to other gesture detector overwrites as well.

The only detector that passes nullable MotionEvents that were marked NonNull was the SimpleStandardOnGestureListener.
What kind of validation do you have in mind?

@yunikkk yunikkk removed the request for review from tobrun August 18, 2022 15:22
@yunikkk yunikkk merged commit 7fbc4f9 into master Aug 19, 2022
@yunikkk yunikkk deleted the yds-fix-nullable-motion-events branch August 19, 2022 09:53
@pengdev
Copy link
Member

pengdev commented Aug 19, 2022

The only detector that passes nullable MotionEvents that were marked NonNull was the SimpleStandardOnGestureListener.
What kind of validation do you have in mind?

I meant in the #95, we have added the NonNull annotation to for example, SimpleStandardOnScaleGestureListener,SimpleStandardOnShoveGestureListener, but indeed it seems the SimpleStandardOnGestureListener is the only listener that extends Android listener and we added NonNull annotations.

@yunikkk
Copy link
Contributor Author

yunikkk commented Aug 22, 2022

Yes, in the other Listeners like SimpleStandardOnShoveGestureListener NonNull annotations are only used for the Detector paremeter eg @NonNull ShoveGestureDetector detector and passed argument is always this so could not be null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants