-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nullable motion events #101
Conversation
@@ -1,5 +1,9 @@ | |||
# Changelog for the Mapbox Gestures for Android | |||
|
|||
## 0.8.0 - | |||
#### Breaking changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also update readme for the repo with instructions how to setup Maps SDK v10?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we validate the NonNull annotations for all the changes introduced in #95 ? it might apply to other gesture detector overwrites as well. |
} | ||
credentials { | ||
username = "mapbox" | ||
password = System.getenv("SDK_REGISTRY_TOKEN") ?: project.property("SDK_REGISTRY_TOKEN") as String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add installation instructions to readme? There's already a small section about the token that will have to get refactored now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only detector that passes nullable MotionEvents that were marked NonNull was the SimpleStandardOnGestureListener. |
I meant in the #95, we have added the NonNull annotation to for example, |
Yes, in the other Listeners like |
Also bumped dependencies and used Maps v10 in the test app
Original ticket - #101