Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bitcode generation #360

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Remove bitcode generation #360

merged 4 commits into from
Sep 18, 2024

Conversation

aleksproger
Copy link
Collaborator

@aleksproger aleksproger commented Sep 12, 2024

We have the following issue in public github, which states that clients who use Xcode 16 for AppStore uploads and use v10 Maps facing issue due to presence of bitcode in our frameworks.

There is a workaround to delete bitcode before using our frameworks, however I think we better should remove bitcode from our v10 stack as it's deprecated already for almost 2 years. Basically, their should be no bitcode users currently as products with bitcode wasn't accepted by AppStore since Xcode 14 introduction.

So in order to unblock customers of v10 and allow to upload their apps to AppStore we must make new minor v10 releases for (mapbox-events-ios, mapbox-common, mapbox-core-maps) without bitcode

Now new binary doesn't contain bitcode
image
While the current one from https://api.mapbox.com/downloads/v2/mapbox-events-ios/releases/ios/packages/1.0.10/MapboxMobileEvents.zip has bitcode
image

@aleksproger aleksproger force-pushed the sapial/remove-bitcode/0 branch 4 times, most recently from f9669d7 to 3c3a45b Compare September 12, 2024 18:10
@tatiana-yan
Copy link
Contributor

new minor v10 releases

New minor v10 releases should not depend on this library, if for some reason dependency exists, it should be removed. We switched to core telemetry between v10.8 and v10.9 more than 2 years ago.
The current v10 release is v10.15

@aleksproger
Copy link
Collaborator Author

current v10 release is v10.15

Current is 10.18 and anyway while we're investigating the reasons for the existence of this dependency I suggest to merge this (without the immediate release) as it at least make this library compatible with modern hardware and CircleCI

@aleksproger aleksproger marked this pull request as ready for review September 16, 2024 16:57
@aleksproger
Copy link
Collaborator Author

So, there is a long discussin in iOS about whether we can drop the distribution of MME, but there is a chance that somebody may use those APIs directly, to be sure let's create a release with this changes it will make the infra up-to-date, remove bitcode and add support for arm64 ios-simulator architecture

@aleksproger aleksproger merged commit 9a6431f into main Sep 18, 2024
3 checks passed
@aleksproger aleksproger deleted the sapial/remove-bitcode/0 branch September 18, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants