-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove bitcode generation #360
Conversation
f9669d7
to
3c3a45b
Compare
3c3a45b
to
55d8447
Compare
New minor v10 releases should not depend on this library, if for some reason dependency exists, it should be removed. We switched to core telemetry between v10.8 and v10.9 more than 2 years ago. |
Current is 10.18 and anyway while we're investigating the reasons for the existence of this dependency I suggest to merge this (without the immediate release) as it at least make this library compatible with modern hardware and CircleCI |
So, there is a long discussin in iOS about whether we can drop the distribution of MME, but there is a chance that somebody may use those APIs directly, to be sure let's create a release with this changes it will make the infra up-to-date, remove bitcode and add support for arm64 ios-simulator architecture |
We have the following issue in public github, which states that clients who use Xcode 16 for AppStore uploads and use v10 Maps facing issue due to presence of bitcode in our frameworks.
There is a workaround to delete bitcode before using our frameworks, however I think we better should remove bitcode from our v10 stack as it's deprecated already for almost 2 years. Basically, their should be no bitcode users currently as products with bitcode wasn't accepted by AppStore since Xcode 14 introduction.
So in order to unblock customers of v10 and allow to upload their apps to AppStore we must make new minor v10 releases for (mapbox-events-ios, mapbox-common, mapbox-core-maps) without bitcode
Now new binary doesn't contain bitcode
While the current one from
https://api.mapbox.com/downloads/v2/mapbox-events-ios/releases/ios/packages/1.0.10/MapboxMobileEvents.zip
has bitcode