Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #299 Replace TrustKit with a single function library for Cert Pinning MMECertPin #117

Merged
merged 18 commits into from
Apr 5, 2019
Merged

Issue #299 Replace TrustKit with a single function library for Cert Pinning MMECertPin #117

merged 18 commits into from
Apr 5, 2019

Conversation

m-stephen
Copy link
Contributor

@m-stephen m-stephen requested a review from alfwatt March 22, 2019 10:11
@codecov-io
Copy link

codecov-io commented Mar 22, 2019 •
edited
Loading

Codecov Report

Merging #117 into master will increase coverage by 5.18%.
The diff coverage is 89.69%.

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   78.28%   83.47%   +5.18%     
==========================================
  Files          83       73      -10     
  Lines        4408     3928     -480     
==========================================
- Hits         3451     3279     -172     
+ Misses        957      649     -308

@friedbunny friedbunny mentioned this pull request Mar 26, 2019
Closed
m-stephen and others added 17 commits April 4, 2019 17:03
@m-stephen
Replace TrustKit with a MMECertPin class
bf50e8a
@m-stephen
Remove some nits and update the test codes
5fa26f0
@m-stephen
Add test case.
7ad4e6f
@m-stephen
Modify a previous test case bug:
61a9ed6 
Cedar's it block is not a sequential execution. The decode codes might be execute before the encode codes, causing test failed.
@m-stephen
Delete useless codes
11a5f8c
@m-stephen
Test codes for cert pinning
7e13e3b
@m-stephen
Delete Logs and increase code cov
587737a
@m-stephen
Fix a bug
b48fdf0
@m-stephen
Fix a bug.
563ae5e
Convert MMEAPIClientCertPinTests to Cedar
34ad940
Improved init and update for MMECertPin
b5fb95c 
Don't compile the pinning sources into the test bundle, load them from the framework
Manually test getPublicKeyDataFromCertificate_legacy_ios
6b13746
Remove vendor
e8daf64
Add MMETestHost.app so we can test keychain mechanics
1de8223
Adjust signing and test host config for CI
98fecac
Testing
777134b
Match the SDK Deployment Target (iOS 8.0) in the Test Host and Storyb…
9932f7b 
…oards
@alfwatt alfwatt requested a review from rclee April 5, 2019 00:08
@alfwatt alfwatt self-assigned this Apr 5, 2019
alfwatt
alfwatt previously approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@alfwatt alfwatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review notes submitted in patch form, mostly improved testing infrastructure

@alfwatt alfwatt self-requested a review April 5, 2019 00:44
alfwatt
alfwatt approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@alfwatt alfwatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alfwatt alfwatt merged commit 6cda727 into master Apr 5, 2019
@rclee rclee deleted the stephen-MMECertPin branch February 12, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfwatt alfwatt alfwatt approved these changes

@rclee rclee Awaiting requested review from rclee

Assignees

@alfwatt alfwatt

Labels
feature tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-stephen @codecov-io @alfwatt