Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates fuel icon #253

Merged
merged 5 commits into from
Apr 15, 2016
Merged

Updates fuel icon #253

merged 5 commits into from
Apr 15, 2016

Conversation

emilymdubois
Copy link
Contributor

@natslaughter I'm at a bit of a sticking point with the fuel icon. I removed the numbers and rounded out the edges to align with perfect circles. After adding some space between the nozzle and the tank, it almost looked like a vacuum cleaner, so I tried to make the hose a little more distinctive.

I feel like there may be 2 outstanding issues:

  • The nozzle shape is a little nondescript, but the original angular shape looked a little too bulky to me
  • The hose looks a little fuzzy to me in the 11px version; we could get rid of the second "kink" but I was unsure how important it is to make the overall shape consistent between the 11px and 15px versions

Any advice or feedback is appreciated!

@natslaughter
Copy link
Contributor

@emilymdubois,

These look great!
Unless you want to take a stab at refining the nozzle shape, these are ready to merge.

@emilymdubois
Copy link
Contributor Author

emilymdubois commented Apr 15, 2016

@natslaughter I made some slight modifications to the nozzles. They feel better to me, but I'd love to hear your thoughts!

It looks like Travis is getting hung up on a few icon files that are saved as <icon_name>-11-01 instead of <icon_name>-11. It also looks like there may be some icons -- veterinary-15, for example -- that have multiple paths in the SVG.

We can either fix these in this branch before we merge into maki-2.0, or we can go ahead and merge with failing Travis tests and fix on a new branch post-merge.

@natslaughter
Copy link
Contributor

@emilymdubois I like the new nozzle. If it looks okay, can you round off the nozzle stroke ending?

Let's go ahead and fix this branch before merging. This would be a great git exercise for me, so could we fix it together?

@emilymdubois
Copy link
Contributor Author

Merge city 🌆

For posterity, @natslaughter and I decided that we will cut a new branch from maki-2.0 when all the icons are finished and fix all the Travis complaints

@emilymdubois emilymdubois merged commit 8e4d33f into maki-2.0 Apr 15, 2016
@emilymdubois emilymdubois deleted the fuel-icon branch April 15, 2016 15:25
@emilymdubois emilymdubois mentioned this pull request Apr 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants