Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Update to Maps SDK 4.6.0 #244

Merged
merged 7 commits into from
Nov 7, 2018
Merged

Update to Maps SDK 4.6.0 #244

merged 7 commits into from
Nov 7, 2018

Conversation

friedbunny
Copy link
Contributor

Ongoing PR for QA of ios-v4.6.0.

/cc @mapbox/maps-ios

@friedbunny
Copy link
Contributor Author

friedbunny commented Oct 24, 2018

Testing out mapbox/mapbox-gl-native#6235 by switching from the podspec URL to ~> 4.6.0-alpha.2.

friedbunny and others added 6 commits November 2, 2018 18:32
> incompatible pointer to integer conversion returning 'id _Nullable' from a function with result type 'BOOL' (aka 'signed char') [-Wint-conversion]
@friedbunny
Copy link
Contributor Author

Rebased to include #231 (and hopefully fix the tests).

Copy link
Contributor

@julianrex julianrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question


COCOAPODS: 1.6.0.beta.1
COCOAPODS: 1.6.0.beta.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When one does bundle install, it’ll install CocoaPods 1.6.0.beta.2 now, instead of beta.1.

Copy link
Contributor Author

@friedbunny friedbunny Nov 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Errr, I misread the file name — since this is Podfile.lock (and not Gemfile.lock), this line refers to the version of CocoaPods that was used to install these pods.

@friedbunny friedbunny self-assigned this Nov 7, 2018
@friedbunny friedbunny merged commit 1489ec8 into master Nov 7, 2018
@friedbunny friedbunny deleted the ios-v4.6.0 branch November 7, 2018 22:47
@friedbunny friedbunny removed the WIP label Nov 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants