This repository has been archived by the owner on May 29, 2024. It is now read-only.
use constructor rather than constructor.name for IE11
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is breaking IE11 support for many mapboxgldraw use cases. Can this be merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IE11 gives undefined for this :
({}).constructor.name.This PR changes the requiredProperty function to check the identity of the constructor rather than the name of it.
fixes #69 and mapbox/mapbox-gl-draw#666
Although this fixes the 99% case, I recommend finding another way of checking for validity, since this will fail for objects created with
Object.create(null).