Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dynamodb-replicator
uses/
as delimiter to hierarchically structurethe data in S3. Up to now it did a naive join of all path parts when
constructing paths and key names for S3. That produced different paths
in S3 whether or not a trailing slash was provided when specifying the
target. For example the following two commands produced different output
files in S3:
As that's different from other tools which interact with S3, like the
official
awscli
this commit changes that behavior to work likepath.join
does, but by using an external package to ensure that alsounder Windows paths are generated with forward slashes.