Add trailing line breaks to incremental backups #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up to now incremental backups didn't contain a trailing line break at the end of the file. When aggregating incremental records into a snapshot `dynamodb-replicator` would add them. This commit changes that to include trailing line breaks in the incremental backups and only add them during snapshotting when they're not present. The motivation for this change is that it makes it significantly easier to process incremental backups with tools such as the `awscli` if they already contain the trailing line break.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to now incremental backups didn't contain a trailing line break at
the end of the file. When aggregating incremental records into a
snapshot
dynamodb-replicatorwould add them.This commit changes that to include trailing line breaks in the
incremental backups and only add them during snapshotting when they're
not present.
The motivation for this change is that it makes it significantly easier
to process incremental backups with tools such as the
awscliif theyalready contain the trailing line break.